[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group
From: |
David Hildenbrand |
Subject: |
Re: [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group |
Date: |
Thu, 2 Dec 2021 17:43:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 02.12.21 17:41, Matthew Rosato wrote:
> The current default PCI group being used can technically collide with a
> real group ID passed from a hostdev. Let's instead use a group ID that comes
> from a special pool that is architected to be reserved for simulated devices.
>
> Fixes: 28dc86a072 ("s390x/pci: use a PCI Group structure")
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
> include/hw/s390x/s390-pci-bus.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h
> index aa891c178d..2727e7bdef 100644
> --- a/include/hw/s390x/s390-pci-bus.h
> +++ b/include/hw/s390x/s390-pci-bus.h
> @@ -313,7 +313,7 @@ typedef struct ZpciFmb {
> } ZpciFmb;
> QEMU_BUILD_BUG_MSG(offsetof(ZpciFmb, fmt0) != 48, "padding in ZpciFmb");
>
> -#define ZPCI_DEFAULT_FN_GRP 0x20
> +#define ZPCI_DEFAULT_FN_GRP 0xFF
> typedef struct S390PCIGroup {
> ClpRspQueryPciGrp zpci_group;
> int id;
>
What happens if we migrate a VM from old to new QEMU? Won't the guest be
able to observe the change?
--
Thanks,
David / dhildenb
- [PATCH 0/4] s390x/pci: some small fixes, Matthew Rosato, 2021/12/02
- [PATCH 4/4] s390x/pci: add supported DT information to clp response, Matthew Rosato, 2021/12/02
- [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group, Matthew Rosato, 2021/12/02
- Re: [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group,
David Hildenbrand <=
- Re: [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group, Matthew Rosato, 2021/12/02
- Re: [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group, David Hildenbrand, 2021/12/02
- Re: [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group, Halil Pasic, 2021/12/02
- Re: [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group, Matthew Rosato, 2021/12/02
- Re: [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group, Pierre Morel, 2021/12/03
- Re: [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group, David Hildenbrand, 2021/12/03
Re: [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group, Eric Farman, 2021/12/02
Re: [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group, Pierre Morel, 2021/12/03
[PATCH 2/4] s390x/pci: don't use hard-coded dma range in reg_ioat, Matthew Rosato, 2021/12/02