[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: SME : Please review and merge : hw/arm/aspeed: Added eMMC boot suppo

From: Cédric Le Goater
Subject: Re: SME : Please review and merge : hw/arm/aspeed: Added eMMC boot support for AST2600 image.
Date: Mon, 29 Nov 2021 18:41:58 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0


On 11/29/21 18:20, Peter Maydell wrote:
On Tue, 9 Nov 2021 at 18:04, Shitalkumar Gandhi <shital_909@yahoo.com> wrote:

Hi SME's,

Please see the attached patch, which has been added to the boot eMMC image for 
AST2600 machine on QEMU.

qemu should be run as follows:

./qemu-system-arm -m 1G -M ast2600-evb -nographic -drive

Tested: Booted AST2600 eMMC image on QEMU.

Suggested-by: Troy Lee leetroy@gmail.com
Reviewed-by: Troy Lee leetroy@gmail.com
Reviewed-by: Andrew Jeffery andrew@aj.id.au
Signed-off-by: Shitalkumar Gandhi shitalkumar.gandhi@seagate.com

Hi; thanks for this patch.

Fishing the patch out of the attachment, the diff is:

Yes. A pull request was sent here also :

The patch is based on the OpenBMC QEMU branch which includes a large
change adding eMMC support to the SD model. But without the eMMC
model upstream, it's pointless, we can only boot from flash.

For the time being, a "boot-emmc" machine option to set/unset the emmc
boot should be enough. It's all in my branch. I think the right approach
would be to use the boot index of the device on the command line to
change the hw strapping.



diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index ba5f1dc5af..6a890adb83 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -148,7 +148,7 @@ struct AspeedMachineState {

  /* AST2600 evb hardware value */
-#define AST2600_EVB_HW_STRAP1 0x000000C0
+#define AST2600_EVB_HW_STRAP1 (0x000000C0 | AST26500_HW_STRAP_BOOT_SRC_EMMC)
  #define AST2600_EVB_HW_STRAP2 0x00000003

  /* Tacoma hardware value */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]