[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/7] vdpa: Add dummy receive callback
From: |
Michael S. Tsirkin |
Subject: |
[PULL 3/7] vdpa: Add dummy receive callback |
Date: |
Mon, 29 Nov 2021 08:51:14 -0500 |
From: Eugenio Pérez <eperezma@redhat.com>
Qemu falls back on userland handlers even if vhost-user and vhost-vdpa
cases. These assumes a tap device can handle the packets.
If a vdpa device fail to start, it can trigger a sigsegv because of
that. Add dummy receiver that returns no progress so it can keep
running.
Fixes: 1e0a84ea49 ("vhost-vdpa: introduce vhost-vdpa net client")
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Message-Id: <20211125101614.76927-2-eperezma@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
---
net/vhost-vdpa.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 2e3c22a8c7..25dd6dd975 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -170,9 +170,17 @@ static bool vhost_vdpa_check_peer_type(NetClientState *nc,
ObjectClass *oc,
return true;
}
+/** Dummy receive in case qemu falls back to userland tap networking */
+static ssize_t vhost_vdpa_receive(NetClientState *nc, const uint8_t *buf,
+ size_t size)
+{
+ return 0;
+}
+
static NetClientInfo net_vhost_vdpa_info = {
.type = NET_CLIENT_DRIVER_VHOST_VDPA,
.size = sizeof(VhostVDPAState),
+ .receive = vhost_vdpa_receive,
.cleanup = vhost_vdpa_cleanup,
.has_vnet_hdr = vhost_vdpa_has_vnet_hdr,
.has_ufo = vhost_vdpa_has_ufo,
--
MST
- [PULL 0/7] virtio,pci,pc: bugfixes, Michael S. Tsirkin, 2021/11/29
- [PULL 1/7] virtio-mmio : fix the crash in the vm shutdown, Michael S. Tsirkin, 2021/11/29
- [PULL 2/7] failover: fix unplug pending detection, Michael S. Tsirkin, 2021/11/29
- [PULL 3/7] vdpa: Add dummy receive callback,
Michael S. Tsirkin <=
- [PULL 4/7] virtio-balloon: process all in sgs for free_page_vq, Michael S. Tsirkin, 2021/11/29
- [PULL 6/7] intel-iommu: ignore leaf SNP bit in scalable mode, Michael S. Tsirkin, 2021/11/29
- [PULL 7/7] Fix bad overflow check in hw/pci/pcie.c, Michael S. Tsirkin, 2021/11/29
- [PULL 5/7] virtio-balloon: correct used length, Michael S. Tsirkin, 2021/11/29
- Re: [PULL 0/7] virtio,pci,pc: bugfixes, Richard Henderson, 2021/11/29