[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] hw/i386: Rename default_bus_bypass_iommu
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 2/2] hw/i386: Rename default_bus_bypass_iommu |
Date: |
Thu, 25 Nov 2021 09:56:42 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Thu, Nov 25, 2021 at 08:12:25AM +0100, Markus Armbruster wrote:
>> Michael & Marcel, this patch fixes a bug that became a regression when
>> the fix missed 6.1. It's been stuck on the list since August. Please
>> have a look, and if it's good, get it merged.
>
>
> Thanks for the reminder. Jean-Philippe, Cc maintainers
> will help patches get merged in a timely manner in the future.
>
>> I just asked the arm/virt
>> maintainer to do the same for PATCH 1.
>
> Some questions below.
>
>> Jean-Philippe Brucker <jean-philippe@linaro.org> writes:
>>
>> > Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine
>> > parameter definitions cannot use underscores, because keyval_dashify()
>> > transforms them to dashes and the parser doesn't find the parameter.
>> >
>> > This affects option default_bus_bypass_iommu which was introduced in the
>> > same release:
>> >
>> > $ qemu-system-x86_64 -M q35,default_bus_bypass_iommu=on
>> > qemu-system-x86_64: Property 'pc-q35-6.1-machine.default-bus-bypass-iommu'
>> > not found
>
> I don't see this behaviour. What did I miss?
I looked at the source and somehow missed that the fix is already there
(commit 739b38630c45). Sorry for the noise!
[...]