qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 05/18] ci: explicitly skip I/O tests on alpine


From: Thomas Huth
Subject: Re: [PATCH v4 05/18] ci: explicitly skip I/O tests on alpine
Date: Wed, 24 Nov 2021 14:36:59 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0

On 24/11/2021 14.01, Daniel P. Berrangé wrote:
The block I/O tests don't work on Alpine because their alternative libc
impl emits different strings for errnos, which breaks the expected
output matching. e.g.

=== IO: pattern 102
  wrote 512/512 bytes at offset 512
  512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-qemu-img: Error while reading offset 0 of 
blkdebug:TEST_DIR/blkdebug.conf:TEST_DIR/t.IMGFMT: Input/output error
+qemu-img: Error while reading offset 0 of 
blkdebug:TEST_DIR/blkdebug.conf:TEST_DIR/t.IMGFMT: I/O error
  4
  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824
  Formatting 'TEST_DIR/t.IMGFMT.2', fmt=IMGFMT size=0

Currently the I/O tests are skipped as a side effect of the Alpine image
containing a minimal busybox 'sed' binary, rather than GNU Sed. This is
a fragile assumption that will be invalidated when the dockerfile is
changed to be autogenerated from a standardized package list that
includes GNU Sed.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
  .gitlab-ci.d/buildtest.yml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 71d0f407ad..e1fe37e563 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -24,7 +24,7 @@ check-system-alpine:
        artifacts: true
    variables:
      IMAGE: alpine
-    MAKE_CHECK_ARGS: check
+    MAKE_CHECK_ARGS: check-unit check-qtest

Hmm, that's just a work-around ... what if some user wants to run "make check" on an Alpine installation that has the real GNU sed installed? ... I think this rather requires some fixing in the iotests instead - or maybe the related tests should simply not be in the "auto" group anymore?

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]