[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support
From: |
gaosong |
Subject: |
Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support |
Date: |
Wed, 24 Nov 2021 15:50:21 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
Hi Richard,
On 2021/11/24 下午3:27, Richard Henderson
wrote:
On
11/24/21 3:46 AM, gaosong wrote:
Hi Richard,
On 2021/11/20 下午6:33, Richard Henderson wrote:
On 11/19/21 7:13 AM, Song Gao wrote:
+
+struct target_sigcontext {
+ uint64_t sc_pc;
+ uint64_t sc_gpr[32];
+ uint64_t sc_fpr[32];
+ uint64_t sc_fcc;
+ uint32_t sc_fcsr;
+ uint32_t sc_flags;
+};
Does not match
https://github.com/loongson/linux/blob/loongarch-next/arch/loongarch/include/uapi/asm/sigcontext.h
#define FPU_REG_WIDTH 256
union fpureg {
uint32_t val32[FPU_REG_WIDTH / 32];
uint64_t val64[FPU_REG_WIDTH / 64];
};
struct target_sigcontext {
uint64_t sc_pc;
uint64_t sc_regs[32];
uint32_t sc_flags;
uint32_t sc_fcsr;
uint32_t sc_vcsr;
uint64_t sc_fcc;
uint64_t scr[4];
union fpureg sc_fpregs[32] __attribute__((aligned(32)));
uint32_t sc_reserved;
};
Is this OK?
No, sc_reserved does not match.
uint8 sc_reserved[4096] __attribute__((aligned(16)));
BTW, should we set scr[0-3] as 0 ?
+
+struct target_ucontext {
+ target_ulong tuc_flags;
+ target_ulong tuc_link;
+ target_stack_t tuc_stack;
+ target_ulong pad0;
+ struct target_sigcontext tuc_mcontext;
+ target_sigset_t tuc_sigmask;
+};
Does not match
https://github.com/loongson/linux/blob/loongarch-next/arch/loongarch/include/uapi/asm/ucontext.h
struct target_ucontext {
target_ulong tuc_flags;
target_ulong tuc_link;
target_stack_t tuc_stack;
target_sigset_t tuc_sigmask;
target_ulong pad0;
struct target_sigcontext tuc_mcontext;
};
Is this OK?
No, pad0 does not match __unused.
uint8 unused[1024 / 8 - sizeof(target_sigset_t)];
Is this right?
Thanks
Song Gao
r~
[PATCH v11 17/26] linux-user: Add LoongArch generic header files, Song Gao, 2021/11/19
[PATCH v11 16/26] target/loongarch: Add disassembler, Song Gao, 2021/11/19
[PATCH v11 22/26] linux-user: Add LoongArch cpu_loop support, Song Gao, 2021/11/19