[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 PATCH 04/13] KVM: Add fd-based memslot data structure and ut
From: |
Chao Peng |
Subject: |
Re: [RFC v2 PATCH 04/13] KVM: Add fd-based memslot data structure and utils |
Date: |
Tue, 23 Nov 2021 22:30:31 +0800 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Tue, Nov 23, 2021 at 09:41:34AM +0100, Paolo Bonzini wrote:
> On 11/19/21 14:47, Chao Peng wrote:
> > For fd-based memslot store the file references for shared fd and the
> > private fd (if any) in the memslot structure. Since there is no 'hva'
> > concept we cannot call hva_to_pfn() to get a pfn, instead kvm_memfd_ops
> > is added to get_pfn/put_pfn from the memory backing stores that provide
> > these fds.
> >
> > Signed-off-by: Yu Zhang<yu.c.zhang@linux.intel.com>
> > Signed-off-by: Chao Peng<chao.p.peng@linux.intel.com>
> > ---
>
> What about kvm_read/write_guest?
Hmm, that would be another area KVM needs to change. Not totally
undoable.
> Maybe the proposal which kept
> userspace_addr for the shared fd is more doable (it would be great to
> ultimately remove the mandatory userspace mapping for the shared fd, but I
> think KVM is not quite ready for that).
Agree for short term keeping shared part unchanged would be making work
easy:) Let me try that to see if any blocker.
>
> Paolo
- Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST, (continued)
- Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST, Jason Gunthorpe, 2021/11/20
- Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST, Paolo Bonzini, 2021/11/23
- Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST, Chao Peng, 2021/11/23
- Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST, David Hildenbrand, 2021/11/23
- Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST, Jason Gunthorpe, 2021/11/23
Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST, Paolo Bonzini, 2021/11/23
[RFC v2 PATCH 02/13] KVM: Add KVM_EXIT_MEMORY_ERROR exit, Chao Peng, 2021/11/19
[RFC v2 PATCH 03/13] KVM: Extend kvm_userspace_memory_region to support fd based memslot, Chao Peng, 2021/11/19
[RFC v2 PATCH 04/13] KVM: Add fd-based memslot data structure and utils, Chao Peng, 2021/11/19
[RFC v2 PATCH 05/13] KVM: Implement fd-based memory using new memfd interfaces, Chao Peng, 2021/11/19
[RFC v2 PATCH 06/13] KVM: Register/unregister memfd backed memslot, Chao Peng, 2021/11/19
[RFC v2 PATCH 07/13] KVM: Handle page fault for fd based memslot, Chao Peng, 2021/11/19
[RFC v2 PATCH 08/13] KVM: Rename hva memory invalidation code to cover fd-based offset, Chao Peng, 2021/11/19
[RFC v2 PATCH 09/13] KVM: Introduce kvm_memfd_invalidate_range, Chao Peng, 2021/11/19