qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v11 04/26] target/loongarch: Add fixed point arithmetic instr


From: Richard Henderson
Subject: Re: [PATCH v11 04/26] target/loongarch: Add fixed point arithmetic instruction translation
Date: Mon, 22 Nov 2021 09:28:35 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 11/22/21 9:23 AM, gaosong wrote:
On 2021/11/20 下午4:56, Richard Henderson wrote:
On 11/20/21 9:52 AM, gaosong wrote:
You're right, gen_set_gpr not need EXT_NONE at all, and we need not condition around gen_set_gpr.
I think that if we know the dst_ext is EXT_NONE, we do't need gen_set_gpr.

But that assumes that gpr_dst did not return a temporary.
I think it's cleaner to assume that gen_set_gpr is needed.

Does this mean that we gen_set_gpr where used gpr_dst, and gen_set_gpr need 
EXT_NONE?
Such as gpr_dst in trans_atomic.c.inc/trans_memory.c.inc, should we need 
gen_set_gpr?

Yes.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]