[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/7] python/aqmp: fix send_fd_scm for python 3.6.x
From: |
Willian Rampazzo |
Subject: |
Re: [PATCH 7/7] python/aqmp: fix send_fd_scm for python 3.6.x |
Date: |
Fri, 19 Nov 2021 13:18:18 -0300 |
On Thu, Nov 18, 2021 at 5:53 PM John Snow <jsnow@redhat.com> wrote:
>
> 3.6 doesn't play keepaway with the socket object, so we don't need to go
> fishing for it on this version. In fact, so long as 'sendmsg' is still
> available, it's probably preferable to just use that method and only go
> fishing for forbidden details when we absolutely have to.
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/aqmp/qmp_client.py | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
- Re: [PATCH 5/7] python/machine: handle "fast" QEMU terminations, (continued)
- [PATCH 2/7] python/machine: remove _remove_monitor_sockfile property, John Snow, 2021/11/18
- [PATCH 4/7] python/machine: move more variable initializations to _pre_launch, John Snow, 2021/11/18
- [PATCH 6/7] scripts/device-crash-test: Use a QMP timeout, John Snow, 2021/11/18
- [PATCH 3/7] python/machine: add instance disambiguator to default nickname, John Snow, 2021/11/18
- [PATCH 7/7] python/aqmp: fix send_fd_scm for python 3.6.x, John Snow, 2021/11/18
- Re: [PATCH 7/7] python/aqmp: fix send_fd_scm for python 3.6.x,
Willian Rampazzo <=