[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] hw/misc/bcm2835_property: Add dummy Get/Set GPIO virt bu
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 2/2] hw/misc/bcm2835_property: Add dummy Get/Set GPIO virt buf messages |
Date: |
Thu, 18 Nov 2021 16:24:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
Hi Benjamin,
On 10/17/21 09:48, Benjamin Herrenschmidt wrote:
> Without these the RaspiOS kernel tries to ioremap some bogus address
> and dumps a backtrace in the console at boot. These work around it.
>
> The virt-gpio driver still fails to initialize but much more cleanly
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> hw/misc/bcm2835_property.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
> index b958fa6a5c..62037c0630 100644
> --- a/hw/misc/bcm2835_property.c
> +++ b/hw/misc/bcm2835_property.c
> @@ -274,6 +274,13 @@ static void
> bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
> resplen = 4;
> break;
>
> + case 0x00048020: /* Set GPIO virt buf */
> + /* fall through */
> + case 0x00040010: /* Get GPIO virt buf */
> + stl_le_phys(&s->dma_as, value + 12, 0);
This is not correct. You tell the kernel it can access the virtbuf
at 0x0000.0000, but the raspi_smpboot code and raspi_spintables are
stored there.
You need to store the uint32_t value in BCM2835PropertyState on SET
and return it on GET.
> + resplen = 4;
> + break;
Regards,
Phil.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 2/2] hw/misc/bcm2835_property: Add dummy Get/Set GPIO virt buf messages,
Philippe Mathieu-Daudé <=