qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] hw/i386/amd_iommu: clean up broken event logging


From: Valentin Sinitsyn
Subject: Re: [PATCH v1] hw/i386/amd_iommu: clean up broken event logging
Date: Thu, 18 Nov 2021 00:19:40 +0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 18.11.2021 00:03, Roman Kagan wrote:
On Wed, Nov 17, 2021 at 11:13:27PM +0500, Valentin Sinitsyn wrote:
On 17.11.2021 19:46, Daniil Tatianin wrote:
-/*
- * AMDVi event structure
- *    0:15   -> DeviceID
- *    55:63  -> event type + miscellaneous info
- *    63:127 -> related address
Did you mean 64:127? Fields shouldn't overlap, and 65-bit address looks
suspicious.

These lines are being removed by this patch.  And yes, they were wrong
WRT the spec.
Oops I missed a minus. Sorry for that.

Valentin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]