qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image


From: Alexey Kardashevskiy
Subject: Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image
Date: Wed, 17 Nov 2021 22:43:31 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0



On 17/11/2021 19:49, Cédric Le Goater wrote:
On 11/17/21 09:39, Richard Henderson wrote:
On 11/16/21 11:48 PM, Alexey Kardashevskiy wrote:
Yup. I am doing SLOF updates this way for ages after diifs became quite huge to make mailman barfing on the size, and the "subsystem" in the subj was the way to reduce the noise Peter had to respond to :)

btw should I be signing those? I am not now.

You could if you and Cedric want to do so (is it really Alexey sending the sub pr and not an impostor with access to the same github account?), but it will not leave a permanent record in the mainline history, because the merge object with the signature will be removed by any rebase.


Yes. I just noticed that the merge commit is lost :

2021-11-09 15:50 +0100 Christophe Lombard                     o [ppc-7.0] {origin/ppc-7.0} pci-host: Allow extended config space access for PowerNV PHB4 model 2021-11-16 17:39 +0100 Cédric Le Goater                       M─┐ Merge tag 'qemu-slof-20211112' of github.com:aik/qemu into ppc-7.0 2021-11-13 14:47 +1100 Alexey Kardashevskiy                   │ o pseries: Update SLOF firmware image 2021-11-12 12:28 +0100 Richard Henderson                      M─│─┐ Merge tag 'pull-ppc-20211112' of https://github.com/legoater/qemu into staging 2021-11-10 17:25 -0300 Daniel Henrique Barboza                │ o─┘ {origin/ppc-for-upstream} {origin/ppc-next} <pull-ppc-20211112> ppc/mmu_helper.c: do not truncate 'ea
...

After rebase :

2021-11-09 15:50 +0100 Christophe Lombard                     o [ppc-7.0] pci-host: Allow extended config space access for PowerNV PHB4 model 2021-11-13 14:47 +1100 Alexey Kardashevskiy                   o pseries: Update SLOF firmware image 2021-11-16 21:07 +0100 Richard Henderson                      o Update version for v6.2.0-rc1 release 2021-11-16 18:55 +0100 Richard Henderson                      M─┐ Merge tag 'pull-nbd-2021-11-16' of https://repo.or.cz/qemu/ericb into staging
...

Alexey's commit appears in the list with only his SoB and we loose :

     Merge tag 'qemu-slof-20211112' of github.com:aik/qemu into ppc-7.0

     * tag 'qemu-slof-20211112' of github.com:aik/qemu:
       pseries: Update SLOF firmware image

     Signed-off-by: Cédric Le Goater <clg@kaod.org>

which I find interesting to identify where the SLOF blob is coming from.


Well, this is a feature of "git rebase" :) The only reliably treceable way I see is storing slof.bin in the SLOF tree.


--
Alexey



reply via email to

[Prev in Thread] Current Thread [Next in Thread]