[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 7/9] linux-user: Remove HAVE_SAFE_SYSCALL and hostdep.h
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v4 7/9] linux-user: Remove HAVE_SAFE_SYSCALL and hostdep.h |
|
Date: |
Wed, 17 Nov 2021 09:22:18 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 11/16/21 12:02, Richard Henderson wrote:
> All supported hosts now define HAVE_SAFE_SYSCALL, so remove
> the ifdefs. This leaves hostdep.h empty, so remove it.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> common-user/host/aarch64/hostdep.h | 18 ------------------
> common-user/host/arm/hostdep.h | 18 ------------------
> common-user/host/i386/hostdep.h | 18 ------------------
> common-user/host/mips/hostdep.h | 2 --
> common-user/host/ppc64/hostdep.h | 18 ------------------
> common-user/host/riscv/hostdep.h | 14 --------------
> common-user/host/s390x/hostdep.h | 18 ------------------
> common-user/host/sparc64/hostdep.h | 2 --
> common-user/host/x86_64/hostdep.h | 18 ------------------
> linux-user/host/ia64/hostdep.h | 15 ---------------
> linux-user/host/mips/hostdep.h | 15 ---------------
> linux-user/host/ppc/hostdep.h | 15 ---------------
> linux-user/host/s390/hostdep.h | 15 ---------------
> linux-user/host/sparc/hostdep.h | 15 ---------------
> linux-user/host/sparc64/hostdep.h | 15 ---------------
> linux-user/host/x32/hostdep.h | 15 ---------------
> linux-user/safe-syscall.h | 12 ------------
> linux-user/user-internals.h | 1 -
> linux-user/signal.c | 2 --
> linux-user/safe-syscall.S | 3 ---
> 20 files changed, 249 deletions(-)
> delete mode 100644 common-user/host/aarch64/hostdep.h
> delete mode 100644 common-user/host/arm/hostdep.h
> delete mode 100644 common-user/host/i386/hostdep.h
> delete mode 100644 common-user/host/mips/hostdep.h
> delete mode 100644 common-user/host/ppc64/hostdep.h
> delete mode 100644 common-user/host/riscv/hostdep.h
> delete mode 100644 common-user/host/s390x/hostdep.h
> delete mode 100644 common-user/host/sparc64/hostdep.h
> delete mode 100644 common-user/host/x86_64/hostdep.h
> delete mode 100644 linux-user/host/ia64/hostdep.h
> delete mode 100644 linux-user/host/mips/hostdep.h
> delete mode 100644 linux-user/host/ppc/hostdep.h
> delete mode 100644 linux-user/host/s390/hostdep.h
> delete mode 100644 linux-user/host/sparc/hostdep.h
> delete mode 100644 linux-user/host/sparc64/hostdep.h
> delete mode 100644 linux-user/host/x32/hostdep.h
> diff --git a/linux-user/safe-syscall.h b/linux-user/safe-syscall.h
> -#ifdef HAVE_SAFE_SYSCALL
>
> /* The core part of this function is implemented in assembly. */
> extern long safe_syscall_base(int *pending, int *errnop, long number, ...);
> @@ -137,15 +136,4 @@ extern char safe_syscall_end[];
> safe_syscall_base(&((TaskState *)thread_cpu->opaque)->signal_pending, \
> &errno, __VA_ARGS__)
>
> -#else
> -
> -/*
> - * Fallback for architectures which don't yet provide a safe-syscall assembly
> - * fragment; note that this is racy!
> - * This should go away when all host architectures have been updated.
> - */
> -#define safe_syscall syscall
> -
> -#endif
Good!
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v4 3/9] linux-user/safe-syscall.inc.S: Move to common-user, (continued)
- [PATCH v4 4/9] common-user: Move syscall error detection into safe_syscall_base, Richard Henderson, 2021/11/16
- [PATCH v4 6/9] common-user/host/sparc64: Add safe-syscall.inc.S, Richard Henderson, 2021/11/16
- [PATCH v4 9/9] common-user: Move safe-syscall.* from *-user, Richard Henderson, 2021/11/16
- [PATCH v4 7/9] linux-user: Remove HAVE_SAFE_SYSCALL and hostdep.h, Richard Henderson, 2021/11/16
- [PATCH v4 5/9] common-user/host/mips: Add safe-syscall.inc.S, Richard Henderson, 2021/11/16
- [PATCH v4 8/9] common-user: Adjust system call return on FreeBSD, Richard Henderson, 2021/11/16
Re: [PATCH v4 0/9] linux-user: simplify safe signal handling, Warner Losh, 2021/11/16