[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] meson: fix botched compile check conversions
From: |
Peter Maydell |
Subject: |
Re: [PATCH] meson: fix botched compile check conversions |
Date: |
Tue, 16 Nov 2021 13:10:04 +0000 |
On Tue, 16 Nov 2021 at 12:00, Daniel P. Berrangé <berrange@redhat.com> wrote:
> I wonder if the problem is more fundamental than that. Passing
> stuff in --extra-cflags is done to influence the flags used to
> compile the QEMU end user binaries. Unfortunately --extra-cflags
> is also getting applied to all the meson.build feature checks.
>
> IMHO we would get a more reliable result if the meson.build
> checks were fully isolated from the cflags we used for building
> everything else, so the checks get a well understood, predictable
> environment.
If you're using --extra-cflags to pass in "-I/path/to/libfoo/headers"
then you do want that to be used in the meson check for "do we have
libfoo", though...
-- PMM