[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/6] pcie: add power indicator blink check
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH 3/6] pcie: add power indicator blink check |
|
Date: |
Mon, 15 Nov 2021 15:52:32 +0100 |
On Mon, Nov 15, 2021 at 06:29:18AM -0500, Michael S. Tsirkin wrote:
> On Mon, Oct 11, 2021 at 02:05:01PM +0200, Gerd Hoffmann wrote:
> > Refuse to push the attention button in case the guest is busy with some
> > hotplug operation (as indicated by the power indicator blinking).
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Can't we do better and press the button later after
> indicator stops blinking?
I don't think this is a good idea. acpi hotplug doesn't do automatic
retries either, and IMHO the behavior of acpi and native hotplug should
be as close as possible so management apps do not need to handle these
cases differently.
Specifically OpenStack will continue re-trying device_del commands
(mentioned by Daniel a few weeks ago) as long as it doesn't receive
the completion event, so things should work just fine as-is.
Beside that the typical workflow would be that the guest completes
device shutdown, then turns off power (-> qemu unplugs device and
sends completion event now), then turns off the power indicator led.
So in most cases the reason to press the button is gone when the
indicator stops blinking ...
take care,
Gerd