Re: [PATCH v4 02/25] include/block/block: split header into I/O and global state API

[Emanuele Giuseppe Esposito]

> > +/*
> > + * I/O API functions. These functions are thread-safe, and therefore
> > + * can run in any thread as long as the thread has called
> > + * aio_context_acquire/release().
> > + */
> > +
> > +int bdrv_replace_child_bs(BdrvChild *child, BlockDriverState *new_bs,
> > +                          Error **errp);
>
> Why is this function here?  Naïvely, I would’ve assumed as a 
> graph-modifying function it should be in block-global-state.h.
>
> I mean, perhaps it’s thread-safe and then it can fit here, too. Still, 
> it surprises me a bit to find this here.
>
> Hanna

Agree, I also tested this, it can go in global state. Will fix that.

Thank you,
Emanuele