[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 07/10] transactions: Invoke clean() after everything else
From: |
Hanna Reitz |
Subject: |
[PATCH v2 07/10] transactions: Invoke clean() after everything else |
Date: |
Thu, 11 Nov 2021 13:08:26 +0100 |
Invoke the transaction drivers' .clean() methods only after all
.commit() or .abort() handlers are done.
This makes it easier to have nested transactions where the top-level
transactions pass objects to lower transactions that the latter can
still use throughout their commit/abort phases, while the top-level
transaction keeps a reference that is released in its .clean() method.
(Before this commit, that is also possible, but the top-level
transaction would need to take care to invoke tran_add() before the
lower-level transaction does. This commit makes the ordering
irrelevant, which is just a bit nicer.)
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
include/qemu/transactions.h | 3 +++
util/transactions.c | 8 ++++++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/include/qemu/transactions.h b/include/qemu/transactions.h
index 92c5965235..2f2060acd9 100644
--- a/include/qemu/transactions.h
+++ b/include/qemu/transactions.h
@@ -31,6 +31,9 @@
* tran_create(), call your "prepare" functions on it, and finally call
* tran_abort() or tran_commit() to finalize the transaction by corresponding
* finalization actions in reverse order.
+ *
+ * The clean() functions registered by the drivers in a transaction are called
+ * last, after all abort() or commit() functions have been called.
*/
#ifndef QEMU_TRANSACTIONS_H
diff --git a/util/transactions.c b/util/transactions.c
index d0bc9a3e73..2dbdedce95 100644
--- a/util/transactions.c
+++ b/util/transactions.c
@@ -61,11 +61,13 @@ void tran_abort(Transaction *tran)
{
TransactionAction *act, *next;
- QSLIST_FOREACH_SAFE(act, &tran->actions, entry, next) {
+ QSLIST_FOREACH(act, &tran->actions, entry) {
if (act->drv->abort) {
act->drv->abort(act->opaque);
}
+ }
+ QSLIST_FOREACH_SAFE(act, &tran->actions, entry, next) {
if (act->drv->clean) {
act->drv->clean(act->opaque);
}
@@ -80,11 +82,13 @@ void tran_commit(Transaction *tran)
{
TransactionAction *act, *next;
- QSLIST_FOREACH_SAFE(act, &tran->actions, entry, next) {
+ QSLIST_FOREACH(act, &tran->actions, entry) {
if (act->drv->commit) {
act->drv->commit(act->opaque);
}
+ }
+ QSLIST_FOREACH_SAFE(act, &tran->actions, entry, next) {
if (act->drv->clean) {
act->drv->clean(act->opaque);
}
--
2.33.1
- [PATCH v2 01/10] stream: Traverse graph after modification, (continued)
- [PATCH v2 01/10] stream: Traverse graph after modification, Hanna Reitz, 2021/11/11
- [PATCH v2 02/10] block: Manipulate children list in .attach/.detach, Hanna Reitz, 2021/11/11
- [PATCH v2 04/10] block: Drop detached child from ignore list, Hanna Reitz, 2021/11/11
- [PATCH v2 03/10] block: Unite remove_empty_child and child_free, Hanna Reitz, 2021/11/11
- [PATCH v2 05/10] block: Pass BdrvChild ** to replace_child_noperm, Hanna Reitz, 2021/11/11
- [PATCH v2 06/10] block: Restructure remove_file_or_backing_child(), Hanna Reitz, 2021/11/11
- [PATCH v2 08/10] block: Let replace_child_tran keep indirect pointer, Hanna Reitz, 2021/11/11
- [PATCH v2 07/10] transactions: Invoke clean() after everything else,
Hanna Reitz <=
- [PATCH v2 10/10] iotests/030: Unthrottle parallel jobs in reverse, Hanna Reitz, 2021/11/11
- [PATCH v2 09/10] block: Let replace_child_noperm free children, Hanna Reitz, 2021/11/11
Re: [PATCH v2 00/10] block: Attempt on fixing 030-reported errors, Kevin Wolf, 2021/11/11