Re: [PULL 05/33] i386: Add 'sgx-epc' device to expose EPC sections to guest

[Thomas Huth]

On 10/11/2021 07.41, Yang Zhong wrote:
> On Tue, Nov 09, 2021 at 06:48:59PM +0100, Paolo Bonzini wrote:
> > On 11/9/21 15:25, Thomas Huth wrote:
> > > Our device-crash-test script reports that this new device can be
> > > used to crash QEMU:
> > >
> > > $ ./qemu-system-x86_64 -M none -device sgx-epc
> > > /home/thuth/devel/qemu/include/hw/i386/pc.h:128:PC_MACHINE: Object
> > > 0x55c80d332290 is not an instance of type generic-pc-machine
> > >
> > > Should it be marked with:
> > >
> > >      dc->user_creatable = false
> > >
> > > ?
> >
> > Yes, it should.  Thanks for the report!
>
>    Thanks Thomas reported this issue!
>
>    I did not know we need do this test before. this test is not
>    covered into Qemu Gitlab CI build system? or what's kind of tests we
>    need do before we send the patches to Qemu community? If there is one
>    guide or CI build including this, which is much better. Thanks!

No worry, device-crash-test is not mandatory, I just have the habit to run 
it and report the new problems when QEMU enters the freeze period for the 
next release.

But you're right, we should ultimatively try to get this included in the CI, 
too, so that the script does not bit-rot so easily anymore...

 Thomas