qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson.build: Support ncurses on MacOS


From: Stefan Weil
Subject: Re: [PATCH] meson.build: Support ncurses on MacOS
Date: Tue, 9 Nov 2021 18:49:57 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

Am 15.06.21 um 03:53 schrieb Brad Smith:

On 6/14/2021 1:45 AM, Philippe Mathieu-Daudé wrote:
On 6/13/21 8:33 AM, Stefan Weil wrote:
Am 13.06.21 um 03:40 schrieb Brad Smith:

This same problem also applies to OpenBSD as we have the same
version of ncurses with support for wide characters. I have a similar
patch in our QEMU port.

Then we should either extend the conditional statement to handle OpenBSD
as well, or simply define both macros unconditionally:

     # Newer versions of curses use NCURSES_WIDECHAR.
     # Older versions (e. g. on MacOS, OpenBSD) still require
_XOPEN_SOURCE_EXTENDED.
     curses_compile_args = ['-DNCURSES_WIDECHAR=1',
'-D_XOPEN_SOURCE_EXTENDED=1']

Defining only _XOPEN_SOURCE_EXTENDED would also work with old and new
versions, so that's another option.
It is simpler to ask Brad to upstream the OpenBSD patch :)

That doesn't answer his question and that's the part that actually matters.


The question is still unanswered: which alternative is preferred?

- define only _XOPEN_SOURCE_EXTENDED=1 unconditionally

- define DNCURSES_WIDECHAR=1 and _XOPEN_SOURCE_EXTENDED=1 unconditionally

- define DNCURSES_WIDECHAR=1 and _XOPEN_SOURCE_EXTENDED=1 for MacOS and BSD

All of them should work. We could also start and merge my commit which does not fix the issue for BSD but at least fixes it for MacOS.

Peter, you added NCURSES_WIDECHAR in commit b01a4fd3bd7d. Which solution would you suggest?

Stefan








reply via email to

[Prev in Thread] Current Thread [Next in Thread]