Re: [PATCH v4 5/5] block: Deprecate transaction type drive-backup

[Vladimir Sementsov-Ogievskiy]

04.11.2021 08:49, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>
> > 25.10.2021 07:24, Markus Armbruster wrote:
> > > Several moons ago, Vladimir posted
> > >
> > >       Subject: [PATCH v2 3/3] qapi: deprecate drive-backup
> > >       Date: Wed,  5 May 2021 16:58:03 +0300
> > >       Message-Id:<20210505135803.67896-4-vsementsov@virtuozzo.com>
> > >       https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg01394.html
> > >
> > > with this
> > >
> > >       TODO: We also need to deprecate drive-backup transaction action..
> > >       But union members in QAPI doesn't support 'deprecated' feature. I tried
> > >       to dig a bit, but failed :/ Markus, could you please help with it? At
> > >       least by advice?
> > >
> > > This is one way to resolve it.  Sorry it took so long.
> > >
> > > John explored another way, namely adding feature flags to union
> > > branches.  Could also be useful, say to add different features to
> > > branches in multiple unions sharing the same tag enum.
> > >
> > > Signed-off-by: Markus Armbruster<armbru@redhat.com>
> >
> > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> >
> > (with simplified commit message of course :)
>
> Your "[PATCH v2 0/3] qapi & doc: deprecate drive-backup" series contains
>
>    docs/block-replication: use blockdev-backup
>    docs/interop/bitmaps: use blockdev-backup
>    qapi: deprecate drive-backup
>
> I figure proper deprecation needs all that, i.e. we need to merge my RFC
> patch into your 3/3.  Could you take care of that?

Of course, but it depend on your 1-4..

Oops, I missed the fact that your 1-4 already applied to master. I will make a 
pull request with deprecations now, may be it's still applicable for 6.2


--
Best regards,
Vladimir