Re: [PATCH v2 3/6] target/i386/sev: Rephrase error message when no hashes table in guest firmware

[Dov Murik]

On 08/11/2021 15:53, Daniel P. Berrangé wrote:
> On Mon, Nov 08, 2021 at 01:48:37PM +0000, Dov Murik wrote:
>> Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
>> ---
>>  target/i386/sev.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/target/i386/sev.c b/target/i386/sev.c
>> index e3abbeef68..c71d23654f 100644
>> --- a/target/i386/sev.c
>> +++ b/target/i386/sev.c
>> @@ -1232,7 +1232,8 @@ bool 
>> sev_add_kernel_loader_hashes(SevKernelLoaderContext *ctx, Error **errp)
>>      }
>>  
>>      if (!pc_system_ovmf_table_find(SEV_HASH_TABLE_RV_GUID, &data, NULL)) {
>> -        error_setg(errp, "SEV: kernel specified but OVMF has no hash table 
>> guid");
>> +        error_setg(errp, "SEV: -kernel specified but guest firmware "
>> +                         "has no hashes table GUID");
> 
> Don't refer to "-kernel" as that's just one way to specifying it. The
> user might have used
> 
>    -machine ....,kernel=/path/to/vmlinux
> 
> Simply "kernel" as the original text has, is fine.
> 

OK, good point. Thanks.

-Dov