[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vhost-user-scsi: fix Kconfig dependencies
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] vhost-user-scsi: fix Kconfig dependencies |
|
Date: |
Mon, 8 Nov 2021 10:53:54 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 11/8/21 10:47, Paolo Bonzini wrote:
> VIRTIO_PCI is a hard dependency for CONFIG_VHOST_USER_SCSI; if virtio-pci
> is not included, linking fails due to missing virtio_pci_types_register.
> Adjust the Kconfig dependencies.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/scsi/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/scsi/Kconfig b/hw/scsi/Kconfig
> index 77d397c949..f972680ffc 100644
> --- a/hw/scsi/Kconfig
> +++ b/hw/scsi/Kconfig
> @@ -50,6 +50,6 @@ config VIRTIO_SCSI
>
> config VHOST_USER_SCSI
> bool
> + default y
> # Only PCI devices are provided for now
> - default y if VIRTIO_PCI
> - depends on VIRTIO && VHOST_USER && LINUX
> + depends on VIRTIO_PCI && VHOST_USER && LINUX
But there is no PCI call there:
$ git grep pci hw/scsi/vhost*scsi*
$
Don't we want to add VHOST_USER_SCSI_PCI in
hw/virtio/Kconfig instead?