[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/6] ui/gtk-egl: un-tab and re-tab should destroy egl surface and
From: |
Gerd Hoffmann |
Subject: |
[PULL 2/6] ui/gtk-egl: un-tab and re-tab should destroy egl surface and context |
Date: |
Fri, 5 Nov 2021 12:30:39 +0100 |
From: Dongwon Kim <dongwon.kim@intel.com>
An old esurface should be destroyed and set to be NULL when doing
un-tab and re-tab so that a new esurface an context can be created
for the window widget that those will be bound to.
v2: enabling opengl specific routines only when CONFIG_OPENGL is set
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@intel.com>
Message-Id: <20211104065153.28897-1-dongwon.kim@intel.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/gtk.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index b0564d80c191..8da673c18c72 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1242,6 +1242,16 @@ static gboolean gd_tab_window_close(GtkWidget *widget,
GdkEvent *event,
vc->tab_item, vc->label);
gtk_widget_destroy(vc->window);
vc->window = NULL;
+#if defined(CONFIG_OPENGL)
+ if (vc->gfx.esurface) {
+ eglDestroySurface(qemu_egl_display, vc->gfx.esurface);
+ vc->gfx.esurface = NULL;
+ }
+ if (vc->gfx.ectx) {
+ eglDestroyContext(qemu_egl_display, vc->gfx.ectx);
+ vc->gfx.ectx = NULL;
+ }
+#endif
return TRUE;
}
@@ -1271,6 +1281,16 @@ static void gd_menu_untabify(GtkMenuItem *item, void
*opaque)
if (!vc->window) {
gtk_widget_set_sensitive(vc->menu_item, false);
vc->window = gtk_window_new(GTK_WINDOW_TOPLEVEL);
+#if defined(CONFIG_OPENGL)
+ if (vc->gfx.esurface) {
+ eglDestroySurface(qemu_egl_display, vc->gfx.esurface);
+ vc->gfx.esurface = NULL;
+ }
+ if (vc->gfx.esurface) {
+ eglDestroyContext(qemu_egl_display, vc->gfx.ectx);
+ vc->gfx.ectx = NULL;
+ }
+#endif
gd_widget_reparent(s->notebook, vc->window, vc->tab_item);
g_signal_connect(vc->window, "delete-event",
--
2.31.1
- [PULL 0/6] Egl 20211105 patches, Gerd Hoffmann, 2021/11/05
- [PULL 1/6] virtio-gpu: splitting one extended mode guest fb into n-scanouts, Gerd Hoffmann, 2021/11/05
- [PULL 2/6] ui/gtk-egl: un-tab and re-tab should destroy egl surface and context,
Gerd Hoffmann <=
- [PULL 3/6] ui/gtk-egl: make sure the right context is set as the current, Gerd Hoffmann, 2021/11/05
- [PULL 5/6] ui/gtk: gd_draw_event returns FALSE when no cairo surface is bound, Gerd Hoffmann, 2021/11/05
- [PULL 6/6] ui/gtk-egl: blitting partial guest fb to the proper scanout surface, Gerd Hoffmann, 2021/11/05
- [PULL 4/6] ui/gtk-egl: guest fb texture needs to be regenerated when reinitializing egl, Gerd Hoffmann, 2021/11/05
- Re: [PULL 0/6] Egl 20211105 patches, Richard Henderson, 2021/11/05