[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 07/20] migration/dirtyrate: implement dirty-ring dirtyrate cal
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PULL 07/20] migration/dirtyrate: implement dirty-ring dirtyrate calculation |
Date: |
Thu, 4 Nov 2021 23:05:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
Hi Juan,
On 11/1/21 23:08, Juan Quintela wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> use dirty ring feature to implement dirtyrate calculation.
>
> introduce mode option in qmp calc_dirty_rate to specify what
> method should be used when calculating dirtyrate, either
> page-sampling or dirty-ring should be passed.
>
> introduce "dirty_ring:-r" option in hmp calc_dirty_rate to
> indicate dirty ring method should be used for calculation.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
Just noticing in the git history some commits from your
pull request have the author name (from + S-o-b) mojibaked.
> Message-Id:
> <7db445109bd18125ce8ec86816d14f6ab5de6a7d.1624040308.git.huangy81@chinatelecom.cn>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> qapi/migration.json | 16 +++-
> migration/dirtyrate.c | 208 +++++++++++++++++++++++++++++++++++++++--
> hmp-commands.hx | 7 +-
> migration/trace-events | 2 +
> 4 files changed, 218 insertions(+), 15 deletions(-)
- [PULL 06/20] migration/dirtyrate: move init step of calculation to main thread, (continued)
- [PULL 06/20] migration/dirtyrate: move init step of calculation to main thread, Juan Quintela, 2021/11/01
- [PULL 08/20] migration: Make migration blocker work for snapshots too, Juan Quintela, 2021/11/01
- [PULL 09/20] migration: Add migrate_add_blocker_internal(), Juan Quintela, 2021/11/01
- [PULL 10/20] dump-guest-memory: Block live migration, Juan Quintela, 2021/11/01
- [PULL 11/20] memory: Introduce replay_discarded callback for RamDiscardManager, Juan Quintela, 2021/11/01
- [PULL 12/20] virtio-mem: Implement replay_discarded RamDiscardManager callback, Juan Quintela, 2021/11/01
- [PULL 13/20] migration/ram: Handle RAMBlocks with a RamDiscardManager on the migration source, Juan Quintela, 2021/11/01
- [PULL 14/20] virtio-mem: Drop precopy notifier, Juan Quintela, 2021/11/01
- [PULL 18/20] migration/ram: Handle RAMBlocks with a RamDiscardManager on background snapshots, Juan Quintela, 2021/11/01
- [PULL 07/20] migration/dirtyrate: implement dirty-ring dirtyrate calculation, Juan Quintela, 2021/11/01
- Re: [PULL 07/20] migration/dirtyrate: implement dirty-ring dirtyrate calculation,
Philippe Mathieu-Daudé <=
- [PULL 19/20] memory: introduce total_dirty_pages to stat dirty pages, Juan Quintela, 2021/11/01
- [PULL 20/20] migration/dirtyrate: implement dirty-bitmap dirtyrate calculation, Juan Quintela, 2021/11/01
- [PULL 16/20] migration: Simplify alignment and alignment checks, Juan Quintela, 2021/11/01
- [PULL 15/20] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination, Juan Quintela, 2021/11/01
- [PULL 17/20] migration/ram: Factor out populating pages readable in ram_block_populate_pages(), Juan Quintela, 2021/11/01
- Re: [PULL 00/20] Migration 20211031 patches, Richard Henderson, 2021/11/02