[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5] tests: qtest: Add virtio-iommu test
From: |
Eric Auger |
Subject: |
Re: [PATCH v5] tests: qtest: Add virtio-iommu test |
Date: |
Thu, 4 Nov 2021 18:40:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
Hi Thomas,
On 11/2/21 2:34 PM, Thomas Huth wrote:
> On 01/11/2021 19.48, Eric Auger wrote:
>> Add the framework to test the virtio-iommu-pci device
>> and tests exercising the attach/detach, map/unmap API.
>>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> Tested-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>>
>> ---
>>
>> v4 -> v5:
>> - remove printf and move a comment
>> - Added Jean-Philippe's T-b and R-b
>> ---
>> tests/qtest/libqos/meson.build | 1 +
>> tests/qtest/libqos/virtio-iommu.c | 126 ++++++++++++
>> tests/qtest/libqos/virtio-iommu.h | 40 ++++
>> tests/qtest/meson.build | 1 +
>> tests/qtest/virtio-iommu-test.c | 326 ++++++++++++++++++++++++++++++
>> 5 files changed, 494 insertions(+)
>> create mode 100644 tests/qtest/libqos/virtio-iommu.c
>> create mode 100644 tests/qtest/libqos/virtio-iommu.h
>> create mode 100644 tests/qtest/virtio-iommu-test.c
>
> There's another failure on Travis-CI:
>
> https://app.travis-ci.com/github/huth/qemu/jobs/546268575#L7240
>
> ERROR:../tests/qtest/virtio-iommu-test.c:38:pci_config:
> assertion failed (domain_range_end == 32): (536870912 == 32)
>
> 536870912 is 0x20000000, so this is likely an endianess issue?
Hum It seems so. Thank you for reporting the issue. I think the
get_config() cb implementation in the virtio-iommu device is wrong and
needs to be fixed.
I will send a fix along with the test.
Thanks!
Eric
>
> Thomas
>