Re: [PATCH] linux-user: Add GPL-2.0+ SPDX license identifier

[Philippe Mathieu-Daudé]

On 11/4/21 10:06, Daniel P. Berrangé wrote:
> On Wed, Nov 03, 2021 at 09:31:46PM +0100, Philippe Mathieu-Daudé wrote:
>> Use Qualcomm License Identifier tool [*] to classify linux-user/
>> files per license type, filtering those matching at least 60% the
>> "GPLv2 or later" type, and manually add the GPL-2.0-or-later SPDX
>> comment.
> 
> When you say  "manually add", can you confirm that you explicitly
> inspected every license header yourself to validate that the reported
> match truely is GPL-2.0+, before adding the SPDX tag.
> 
> Adding licenses tags based merely on a 60% match, without doing
> human inspection would be questionable.

Yes I explicitly inspected every license error before manually add
the tag, but I am human, so prone to errors, which is why peer
review is important :)

This diff is generated using 'git-format-patch --unified=4' because
I thought it would ease review, however I just realize reviewers can't
check from the diff whether there is another license in the file.

In v2 I moved the tag to the first line and generated the diff using
'git-format-patch --unified=20' which is better because in almost all
cases the full header is displayed. I might use '--function-context'
in eventual v3, but it is slightly more verbose (it displays everything
until the first function, so all #include / #define after the header).