[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] virtio-gpu: splitting one extended mode guest fb into

From: Dongwon Kim
Subject: Re: [PATCH v2 1/2] virtio-gpu: splitting one extended mode guest fb into n-scanouts
Date: Thu, 4 Nov 2021 00:19:37 -0700
User-agent: Mutt/1.9.4 (2018-02-28)

I found the virtio-gpu-splitting-one-extended-mode-guest-fb-into.patch
didn't include the func interface change in one of stubs. I believe
that was the reason for win32/64 build failure (verified it with gitlab
CI). I updated that patch then I combined all 6 (4 for untabifying issue
and 2 for multiple guest scanouts with blob) into one patch series and just
sent it to as a reply.

Regarding Vivek's series for default sync mechanism that you referred
below, that series has already been merged.


On Wed, Nov 03, 2021 at 06:39:37AM +0100, Gerd Hoffmann wrote:
> On Tue, Nov 02, 2021 at 05:41:10PM -0700, Dongwon Kim wrote:
> > I double-checked the patch and also tried to build with --disable-opengl
> > but couldn't find any issue. Can you please give me some hint? Like
> > build errors you saw. What are changed by the patch are pretty much
> > limited to virtio-gpu blob case and just one change in common area is
> > egl_fb_blit function but the function interface stays same and there are
> > no variables enabled only with certain define.
> > 
> > Is there any chance that the build system was building it with the
> > previous patch, "ui/gtk-egl: un-tab and re-tab should destroy egl
> > surface and context" still applied?
> Hmm, I had applied both, then dropped the failing series, but possibly I
> missed some broken patch.
> Trying to apply the series on top of the v2 just sent failed.
> Any chance you can send a single patch series with all pending patches
> (including the "virtio-gpu: Add a default synchronization mechanism for
> blobs" series by Vivek which also doesn't apply cleanly any more)?
> Ideally tested in gitlab ci?
> thanks,
>   Gerd

reply via email to

[Prev in Thread] Current Thread [Next in Thread]