[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 15/23] target/mips: Extract break code into env->error_cod
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3 15/23] target/mips: Extract break code into env->error_code |
|
Date: |
Wed, 3 Nov 2021 18:01:23 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 11/3/21 16:38, Richard Henderson wrote:
> On 11/3/21 11:11 AM, Philippe Mathieu-Daudé wrote:
>>> + /*
>>> + * As described in the original Linux kernel code, the
>>> below
>>> + * checks on 'code' are to work around an old assembly bug.
>>> + */
>>> + code = env->error_code;
>>> + if (code >= (1 << 10)) {
>>> + code >>= 10;
>>
>> Shouldn't we also move this to the translation (not in R6_BREAK16)?
>
> No, because it's a kernel thing, not a cpu thing:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/mips/kernel/traps.c#n1056
Oh indeed, I see.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> PS: Just above, it looks like the kernel would need to grow support for
> R6_BREAK. At present it only handles mips16e and micromips.
>
- [PATCH v3 07/23] linux-user/hppa: Set FPE_CONDTRAP for COND, (continued)
- [PATCH v3 07/23] linux-user/hppa: Set FPE_CONDTRAP for COND, Richard Henderson, 2021/11/03
- [PATCH v3 08/23] linux-user/i386: Split out maybe_handle_vm86_trap, Richard Henderson, 2021/11/03
- [PATCH v3 10/23] linux-user/m68k: Use force_sig_fault, Richard Henderson, 2021/11/03
- [PATCH v3 11/23] linux-user/microblaze: Use force_sig_fault, Richard Henderson, 2021/11/03
- [PATCH v3 12/23] linux-user/microblaze: Fix SIGFPE si_codes, Richard Henderson, 2021/11/03
- [PATCH v3 14/23] linux-user/mips: Use force_sig_fault, Richard Henderson, 2021/11/03
- [PATCH v3 13/23] linux-user/mips: Improve do_break, Richard Henderson, 2021/11/03
- [PATCH v3 15/23] target/mips: Extract break code into env->error_code, Richard Henderson, 2021/11/03
- [PATCH v3 16/23] target/mips: Extract trap code into env->error_code, Richard Henderson, 2021/11/03
[PATCH v3 20/23] linux-user/s390x: Use force_sig_fault, Richard Henderson, 2021/11/03
[PATCH v3 17/23] linux-user/openrisc: Use force_sig_fault, Richard Henderson, 2021/11/03
[PATCH v3 18/23] linux-user/ppc: Use force_sig_fault, Richard Henderson, 2021/11/03
[PATCH v3 21/23] linux-user/sh4: Use force_sig_fault, Richard Henderson, 2021/11/03
[PATCH v3 19/23] linux-user/riscv: Use force_sig_fault, Richard Henderson, 2021/11/03