[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 00/17] iotests: support zstd

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v3 00/17] iotests: support zstd
Date: Wed, 3 Nov 2021 16:01:12 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

02.11.2021 15:29, Kevin Wolf wrote:
Am 17.09.2021 um 20:06 hat Vladimir Sementsov-Ogievskiy geschrieben:
17.09.2021 17:49, Hanna Reitz wrote:
On 15.09.21 16:45, Hanna Reitz wrote:
On 14.09.21 12:25, Vladimir Sementsov-Ogievskiy wrote:
These series makes tests pass with


Also, python iotests start to support IMGOPTS (they didn't before).

Unfortunately, the problem I have now is that it makes the tests fail with 
other IMGOPTS.

My regular test set includes 'refcount_bits=1', 'compat=0.10', and 
'data_file=$TEST_IMG.ext_data_file'.  These fail now, because the Python tests 
don’t have a way to specify which test options they don’t support (like 
_unsupported_imgopts).  Handling data_file of course is extra tricky because 
now every disk image consists of two files, and the qemu-img create invocation 
needs to expand '$TEST_IMG', like _make_test_img does (in the line where 
imgopts_expanded is set).

I think we need an unsupported_imgopts parameter for Python tests, and it needs 
to be filled (perhaps 
https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg00082.html can 
serve as a starting point).  And for the time being, I think Python tests 
should be skipped altogether when IMGOPTS contains data_file.

(Perhaps I should explicitly say that this means I didn’t include this series 
in my pull request this week, because, well, my pre-pull tests were failing :/)

That was clean :) I'll resend

Am I missing something or has this not happened yet?

Not happened yet :(

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]