[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/10] usb-storage: tag usb_msd_csw as packed struct
From: |
Gerd Hoffmann |
Subject: |
[PULL 10/10] usb-storage: tag usb_msd_csw as packed struct |
Date: |
Tue, 2 Nov 2021 17:26:19 +0100 |
Without this the struct has the wrong size: sizeof() evaluates
to 16 instead of 13. In most cases the bug is hidden by the
fact that guests submits a buffer which is exactly 13 bytes
long, so the padding added by the compiler is simply ignored.
But sometimes guests submit a larger buffer and expect a short
transfer, which does not work properly with the wrong struct
size.
Cc: vintagepc404@protonmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Fixes: a917d384ac0 ("SCSI TCQ support.")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210906045523.1259629-1-kraxel@redhat.com>
---
include/hw/usb/msd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/usb/msd.h b/include/hw/usb/msd.h
index 7538c54569bf..54e9f38bda46 100644
--- a/include/hw/usb/msd.h
+++ b/include/hw/usb/msd.h
@@ -17,7 +17,7 @@ enum USBMSDMode {
USB_MSDM_CSW /* Command Status. */
};
-struct usb_msd_csw {
+struct QEMU_PACKED usb_msd_csw {
uint32_t sig;
uint32_t tag;
uint32_t residue;
--
2.31.1
- [PULL 00/10] Misc 20211102 patches, Gerd Hoffmann, 2021/11/02
- [PULL 02/10] MAINTAINERS: add myself as partial audio reviewer, Gerd Hoffmann, 2021/11/02
- [PULL 01/10] MAINTAINERS: Add myself as a reviewer for SDL audio, Gerd Hoffmann, 2021/11/02
- [PULL 04/10] ui/gtk: Update the refresh rate for gl-area too, Gerd Hoffmann, 2021/11/02
- [PULL 05/10] ui/gtk: skip any extra draw of same guest scanout blob res, Gerd Hoffmann, 2021/11/02
- [PULL 09/10] hw/misc: deprecate the 'sga' device, Gerd Hoffmann, 2021/11/02
- [PULL 03/10] microvm: add device tree support., Gerd Hoffmann, 2021/11/02
- [PULL 07/10] ui/console: replace kbd_timer with chr_accept_input callback, Gerd Hoffmann, 2021/11/02
- [PULL 08/10] ui/console: remove chardev frontend connected test, Gerd Hoffmann, 2021/11/02
- [PULL 10/10] usb-storage: tag usb_msd_csw as packed struct,
Gerd Hoffmann <=
- [PULL 06/10] ui/console: replace QEMUFIFO with Fifo8, Gerd Hoffmann, 2021/11/02
- Re: [PULL 00/10] Misc 20211102 patches, Richard Henderson, 2021/11/03