Re: [PATCH v3 20/32] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4)

[Philippe Mathieu-Daudé]

On 10/29/21 19:50, Richard Henderson wrote:
> On 10/29/21 10:23 AM, Philippe Mathieu-Daudé wrote:
>> On 10/29/21 18:35, Richard Henderson wrote:
>>> On 10/28/21 2:08 PM, Philippe Mathieu-Daudé wrote:
>>>> +@3r                 ...... ...  df:2 wt:5ws:5  wd:5 ......  &msa_r
>>>
>>> Nit: should this be called @3rf, since it includes df and...
>>
>> "3R" is how the manual names this instruction class:
>>
>>    Figure 3-40 3R Instruction Format
>>
>> 3R has 2-bit DF field, 3RF has 1-bit DF field. The other
>> arguments are the same (for the helpers).
> 
> Ok, I see.

FYI I amended:

    Note, the format definition could be named @3rf_b (for
    3R with a df field BYTE-based) but since the instruction
    class is named '3R', we simply call the format @3r to
    ease reviewing the msa.decode file.
    However we directly call the trans_msa_3rf() function,
    which handles the BYTE-based df field.

to the commit description.