Re: [PATCH] meson: remove unnecessary coreaudio test program

[Paolo Bonzini]

On 02/11/21 12:49, Peter Maydell wrote:
> >     coreaudio = dependency('appleframeworks', modules: 'CoreAudio',
> >                            required: get_option('coreaudio'))
> > -  if coreaudio.found() and not cc.links('''
> > -    #include <CoreAudio/CoreAudio.h>
> > -    int main(void)
> > -    {
> > -      return (int)AudioGetCurrentHostTime();
> > -    }''')
> > -    coreaudio = not_found
> > -  endif
> > -
> > -  if not coreaudio.found()
> > -    if get_option('coreaudio').enabled()
> > -      error('CoreAudio not found')
> > -    else
> > -      warning('CoreAudio not found, disabling')
> > -    endif
> > -  endif
> >   endif
> Don't we still want
>
>    if not coreaudio.found()
>      if get_option('coreaudio').enabled()
>        error('CoreAudio not found')
>      endif
>    endif

No, the "required: get_option('coreaudio')" takes care of both forced 
enabling and forced disabling.

Paolo