[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] migration: provide an error message to migration_cancel(
From: |
Juan Quintela |
Subject: |
Re: [PATCH 1/2] migration: provide an error message to migration_cancel() |
Date: |
Tue, 02 Nov 2021 10:04:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Laurent Vivier <lvivier@redhat.com> wrote:
> This avoids to call migrate_get_current() in the caller function
> whereas migration_cancel() already needs the pointer to the current
> migration state.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued.
> error_setg(&err, "RAM block '%s' resized during precopy.",
> rb->idstr);
> - migrate_set_error(migrate_get_current(), err);
> + migration_cancel(err);
> error_free(err);
> - migration_cancel();
This was already there, but it is ugly, isn't it?
Later, Juan.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 1/2] migration: provide an error message to migration_cancel(),
Juan Quintela <=