[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no
|
From: |
Juan Quintela |
|
Subject: |
Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq |
|
Date: |
Tue, 02 Nov 2021 08:39:37 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Tue, Nov 02, 2021 at 08:25:27AM +0100, Juan Quintela wrote:
>> Eugenio Pérez <eperezma@redhat.com> wrote:
>> > The -1 assumes that all devices with no cvq have an spare vq allocated
>> > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the
>> > case, and the device may have a pair number of queues.
>> ^^^^
>> even
>>
>> I know, I know, I am Spanish myself O:-)
>
> Nobody expects the Spanish ;)
O:-)
>> int main(void)
>> {
>> int i = 7;
>> i &= -1ULL;
>
> Stefano's patch has ~1ULL , not -1ULL here.
>
Stupid eyes.
Thanks, Juan.