Re: [RFC PATCH v5 12/26] vhost: Route guest->host notification through shadow virtqueue

[Eugenio Perez Martin]

On Tue, Nov 2, 2021 at 6:36 AM Jason Wang <jasowang@redhat.com> wrote:
>
>
> 在 2021/10/30 上午2:35, Eugenio Pérez 写道:
> > +/**
> > + * Enable or disable shadow virtqueue in a vhost vdpa device.
> > + *
> > + * This function is idempotent, to call it many times with the same value 
> > for
> > + * enable_svq will simply return success.
> > + *
> > + * @v       Vhost vdpa device
> > + * @enable  True to set SVQ mode
> > + * @errp    Error pointer
> > + */
> > +void vhost_vdpa_enable_svq(struct vhost_vdpa *v, bool enable, Error **errp)
> > +{
>
>
> What happens if vhost_vpda is not stated when we try to enable svq?
> Another note is that, the vhost device could be stopped and started
> after svq is enabled/disabled. We need to deal with them.
>

Right, I didn't append it to the TODO list but it is in development.

Thanks!

> Thanks
>