qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 8/9] migration/ram: Factor out populating pages readable i


From: Juan Quintela
Subject: Re: [PATCH v1 8/9] migration/ram: Factor out populating pages readable in ram_block_populate_pages()
Date: Mon, 01 Nov 2021 19:32:20 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

David Hildenbrand <david@redhat.com> wrote:
> Let's factor out prefaulting/populating to make further changes easier to
> review and add a comment what we are actually expecting to happen. While at
> it, use the actual page size of the ramblock, which defaults to
> qemu_real_host_page_size for anonymous memory. Further, rename
> ram_block_populate_pages() to ram_block_populate_read() as well, to make
> it clearer what we are doing.
>
> In the future, we might want to use MADV_POPULATE_READ to speed up
> population.
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]