Re: [PATCH v6 13/66] linux-user/host/s390: Populate host_signal.h

[Thomas Huth]

On 30/10/2021 19.15, Richard Henderson wrote:
> Split host_signal_pc and host_signal_write out of user-exec.c.
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   linux-user/host/s390/host-signal.h  | 93 ++++++++++++++++++++++++++++-
>   linux-user/host/s390x/host-signal.h |  2 +-
>   accel/tcg/user-exec.c               | 88 +--------------------------
>   3 files changed, 94 insertions(+), 89 deletions(-)
>
> diff --git a/linux-user/host/s390/host-signal.h 
> b/linux-user/host/s390/host-signal.h
> index f4b4d65031..21f59b612a 100644
> --- a/linux-user/host/s390/host-signal.h
> +++ b/linux-user/host/s390/host-signal.h
> @@ -1 +1,92 @@
> -#define HOST_SIGNAL_PLACEHOLDER
> +/*
> + * host-signal.h: signal info dependent on the host architecture
> + *
> + * Copyright (C) 2021 Linaro Limited

Since you moved code around, should this file also bear the original 
copyright statement?

OTOH, if I've got that right, the code has change locations a couple of 
times already, so the original statement might not match the code anyway.

> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.

License changes from LGPL to GPL - intended? (I personally don't mind, I 
just wanted to check whether this was on purpose or by accident)

 Thomas