[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 6/6] hw/input/lasips2: QOM'ify the Lasi PS/2

From: Richard Henderson
Subject: Re: [PULL 6/6] hw/input/lasips2: QOM'ify the Lasi PS/2
Date: Mon, 1 Nov 2021 11:31:19 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 11/1/21 4:27 AM, Laurent Vivier wrote:
From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
Message-Id: <20210920064048.2729397-4-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
  hw/hppa/lasi.c             | 10 +++++++++-
  hw/input/lasips2.c         | 38 ++++++++++++++++++++++++++++----------
  include/hw/input/lasips2.h | 17 +++++++++++++----
  3 files changed, 50 insertions(+), 15 deletions(-)

This has broken the qtest-hppa device-introspection test:

ERROR:../src/qom/object.c:2011:object_get_canonical_path_component: code should 
not be reached
Broken pipe
Aborted (core dumped)

Also, the previous patch 5 does not compile on its own:

In file included from ../src/hw/input/lasips2.c:28:0:
/home/richard.henderson/qemu/src/include/hw/input/lasips2.h:17:18: error: field ‘reg’ has incomplete type
     MemoryRegion reg;
ninja: build stopped: subcommand failed.

Reverting to patch 4 builds, and passes the introspection test.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]