Re: [PULL 03/26] configure, meson: move audio driver detection to Meson

[Peter Maydell]

On Thu, 14 Oct 2021 at 17:37, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> This brings a change that makes audio drivers more similar to all
> other modules.  All drivers are built by default, while
> --audio-drv-list only governs the default choice of the audio driver.
>
> Meson options are added to disable the drivers, and the next patches
> will fix the help messages and command line options, and especially
> make the non-default drivers available via -audiodev.
>
> Cc: Gerd Hoffman <kraxel@redhat.com>
> Cc: Volker Rümelin <vr_qemu@t-online.de>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Message-Id: <20211007130630.632028-4-pbonzini@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Hi; this change seems to have caused meson to produce new
WARNING messages on OSX host:

Library rados found: NO
Has header "rbd/librbd.h" : NO
Run-time dependency glusterfs-api found: NO (tried pkgconfig)
Has header "bzlib.h" : YES
Library bz2 found: YES
Has header "lzfse.h" : NO
Has header "sys/soundcard.h" : NO
../../meson.build:928: WARNING: OSS not found, disabling
Run-time dependency appleframeworks found: YES (CoreAudio)
../../meson.build:964: WARNING: CoreAudio not found, disabling
Run-time dependency gnutls found: YES 3.6.15
Run-time dependency libpng found: YES 1.6.37

"I didn't find some optional thing" should not be emitting
warning messages.

Also, the CoreAudio test seems to be broken (never detects
CoreAudio). According to meson.log we do this:

Run-time dependency appleframeworks found: YES (CoreAudio)
Running compile:
Working directory:
/Users/pm215/src/qemu-for-merges/build/all/meson-private/tmp7k9rfdt5
Command line:  cc
/Users/pm215/src/qemu-for-merges/build/all/meson-private/tmp7k9rfdt5/testfile.c
-o 
/Users/pm215/src/qemu-for-merges/build/all/meson-private/tmp7k9rfdt5/output.exe
-O0 -Werror=implicit-function-declaration -std=gnu11

Code:

    #include <CoreAudio/CoreAudio.h>
    int main(void)
    {
      return (int)AudioGetCurrentHostTime();
    }
Compiler stdout:

Compiler stderr:
 Undefined symbols for architecture x86_64:
  "_AudioGetCurrentHostTime", referenced from:
      _main in testfile-96e6d2.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

../../meson.build:964: WARNING: CoreAudio not found, disabling

which is to say, we try to link the test program but
we have forgotten to say "and we need to link
against coreaudio" when doing so. In the old configure
version this was done using
   if compile_prog "" "$coreaudio_libs" ; then
thus passing "-framework CoreAudio" to the compiler;
I don't know what the meson equivalent is.

thanks
-- PMM