Re: [PATCH v3 34/48] tcg/optimize: Split out fold_to_not

[Richard Henderson]

On 10/25/21 11:13 AM, Luis Fernando Fujita Pires wrote:
> From: Richard Henderson <richard.henderson@linaro.org>
>
> > > >    static bool fold_eqv(OptContext *ctx, TCGOp *op)  {
> > > > -    return fold_const2(ctx, op);
> > > > +    if (fold_const2(ctx, op) ||
> > > > +        fold_xi_to_not(ctx, op, 0)) {
> > >
> > > Should be fold_ix_to_not (not fold xi_to_not).
> >
> > No, because for eqv we expect the second operand to be the constant -- eqv is
> > commutative.
>
> Ah, got it! The previous code was wrong, and I failed to notice that eqv 
> would've had its arguments swapped to have the constant as second.

Ah!  I failed to notice that the previous code was wrong.  ;-)


r~