Re: [PATCH v3 18/21] target/riscv: modification of the trans

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 18/21] target/riscv: modification of the trans_csrxx for 1

From:	Richard Henderson
Subject:	Re: [PATCH v3 18/21] target/riscv: modification of the trans_csrxx for 128-bit support
Date:	Wed, 20 Oct 2021 14:53:34 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/19/21 2:48 AM, Frédéric Pétrot wrote:

As opposed to the gen_arith and gen_shift generation helpers, the csr insns
do not have a common prototype, so the choice to generate 32/64 or 128-bit
helper calls is done in the trans_csrxx functions.

Signed-off-by: Frédéric Pétrot<frederic.petrot@univ-grenoble-alpes.fr>
Co-authored-by: Fabien Portas<fabien.portas@grenoble-inp.org>
---
  target/riscv/insn_trans/trans_rvi.c.inc | 201 ++++++++++++++++++------
  1 file changed, 156 insertions(+), 45 deletions(-)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 13/21] target/riscv: support for 128-bit shift instructions, (continued)
- [PATCH v3 13/21] target/riscv: support for 128-bit shift instructions, Frédéric Pétrot, 2021/10/19
  - Re: [PATCH v3 13/21] target/riscv: support for 128-bit shift instructions, Richard Henderson, 2021/10/20
- [PATCH v3 15/21] target/riscv: support for 128-bit M extension, Frédéric Pétrot, 2021/10/19
  - Re: [PATCH v3 15/21] target/riscv: support for 128-bit M extension, Richard Henderson, 2021/10/20
- [PATCH v3 20/21] target/riscv: adding 128-bit access functions for some csrs, Frédéric Pétrot, 2021/10/19
- [PATCH v3 21/21] target/riscv: support for 128-bit satp, Frédéric Pétrot, 2021/10/19
  - Re: [PATCH v3 21/21] target/riscv: support for 128-bit satp, Richard Henderson, 2021/10/20
- [PATCH v3 17/21] target/riscv: helper functions to wrap calls to 128-bit csr insns, Frédéric Pétrot, 2021/10/19
  - Re: [PATCH v3 17/21] target/riscv: helper functions to wrap calls to 128-bit csr insns, Richard Henderson, 2021/10/20
- [PATCH v3 18/21] target/riscv: modification of the trans_csrxx for 128-bit support, Frédéric Pétrot, 2021/10/19
  - Re: [PATCH v3 18/21] target/riscv: modification of the trans_csrxx for 128-bit support, Richard Henderson <=
- [PATCH v3 16/21] target/riscv: adding high part of some csrs, Frédéric Pétrot, 2021/10/19
  - Re: [PATCH v3 16/21] target/riscv: adding high part of some csrs, Richard Henderson, 2021/10/20
  - Re: [PATCH v3 16/21] target/riscv: adding high part of some csrs, Richard Henderson, 2021/10/20
- [PATCH v3 19/21] target/riscv: actual functions to realize crs 128-bit insns, Frédéric Pétrot, 2021/10/19
  - Re: [PATCH v3 19/21] target/riscv: actual functions to realize crs 128-bit insns, Richard Henderson, 2021/10/20

Prev by Date: Re: [PATCH v3 17/21] target/riscv: helper functions to wrap calls to 128-bit csr insns
Next by Date: Re: [PATCH v2 1/5] aspeed/wdt: Introduce a container for the MMIO region
Previous by thread: [PATCH v3 18/21] target/riscv: modification of the trans_csrxx for 128-bit support
Next by thread: [PATCH v3 16/21] target/riscv: adding high part of some csrs
Index(es):
- Date
- Thread