Re: [PATCH v6 08/12] target/hexagon: import lexer for idef-parser

[Anton Johansson]

On 9/7/21 18:08, Taylor Simpson wrote:

> > +"fNEWREG"                |
> > +"fCAST4s"                { yylval->cast.bit_width = 32;
> > +                           yylval->cast.signedness = SIGNED;
> > +                           return CAST; }
> >       
> This doesn't look right - is fNEWREG the same as fCAST4s?
>

We followed the definition of fNEWREG in macros.h where it is given as

  #define fNEWREG(VAL) ((uint32_t) (VAL))

> > +"fCONSTLL"               { return CONSTLL; }
> > +"fCONSTULL"              { return CONSTULL; }
> >       
> These can just be converts.
>

What is meant by "converts" here?

> > +"fHINTJR(RsV)"           { /* Emit no token */ }
> >         
> Put this in the list of IDENTITY above
>       
      Same as for fNEWREG. We followed the definition in macros.h as

  #define fHINTJR(TARGET) { /* Not modelled in qemu */ }

    where it no-ops.
-- 
Anton Johansson,
rev.ng Srls.