Re: [PATCH 5/8] linux-user: Support TCG_TARGET_SIGNED_ADDR32

[Richard Henderson]

On 10/11/21 3:22 AM, Alex Bennée wrote:
> Richard Henderson <richard.henderson@linaro.org> writes:
>
> > When using reserved_va, which is the default for a 64-bit host
> > and a 32-bit guest, set guest_base_signed_addr32 if requested
> > by TCG_TARGET_SIGNED_ADDR32, and the executable layout allows.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   include/exec/cpu-all.h |  4 ---
> >   linux-user/elfload.c   | 62 ++++++++++++++++++++++++++++++++++--------
> >   2 files changed, 50 insertions(+), 16 deletions(-)
> >
> > diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
> > index 80b5e17329..71d8e1de7a 100644
> > --- a/include/exec/cpu-all.h
> > +++ b/include/exec/cpu-all.h
> > @@ -278,11 +278,7 @@ extern intptr_t qemu_host_page_mask;
> >   #define PAGE_RESET     0x0040
> >   /* For linux-user, indicates that the page is MAP_ANON. */
> >   #define PAGE_ANON      0x0080
> > -
> > -#if defined(CONFIG_BSD) && defined(CONFIG_USER_ONLY)
> > -/* FIXME: Code that sets/uses this is broken and needs to go away.  */
> >   #define PAGE_RESERVED  0x0100
> > -#endif
>
> Can we reference why this FIXME is being dropped in the commit message?

I'm not sure to what pbrook was referring with "... and is already broken" there.  I need 
something here to reserve a page, PAGE_RESERVED seems like a good name, so I took it out 
of the cupboard.

I'll do some archaeology.


r~

> Looking at the current tree state I can see several uses of it due to
> moves in 5b6dd8683d (exec: move TB handling to translate-all.c) which
> post-date 2e9a5713f0 (Remove PAGE_RESERVED).
>
> Otherwise looks reasonable:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>