qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v12 16/16] machine: Make smp_parse return a boolean


From: Paolo Bonzini
Subject: Re: [PATCH v12 16/16] machine: Make smp_parse return a boolean
Date: Thu, 7 Oct 2021 10:29:34 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 02/10/21 13:27, Markus Armbruster wrote:
The "return a boolean" rule adds some complexity (and
a possibility for things to be wrong/inconsistent) to the function for
the benefit of the callers.
Yes, but returning something is only a minor burden.  It also makes
success vs. failure obvious at a glance.

Fair enough; I'd still prefer to have an exception to the rule for virtual functions. In that case, I really find the benefit to be negative.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]