[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 14/22] target/i386/sev: Move qmp_query_sev_attestation_rep
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3 14/22] target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c |
|
Date: |
Wed, 6 Oct 2021 22:45:26 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 10/4/21 10:23, Paolo Bonzini wrote:
> On 02/10/21 14:53, Philippe Mathieu-Daudé wrote:
>> Move qmp_query_sev_attestation_report() from monitor.c to sev.c
>> and make sev_get_attestation_report() static. We don't need the
>> stub anymore, remove it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> This was done on purpose, but I have no objection to changing it this
> way. We might in fact remove the indirection for SGX as well, and/or
> even move the implementation of the monitor commands from target/i386 to
> hw/i386 (the monitor is sysemu-specific).
OK about SGX, but in another series, this one is already painful enough.
Not sure about moving monitor to hw/, some commands expose hw info (like
info pic) but some others expose architectural features (like info sev).
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Thanks,
>
> Paolo
- [PATCH v3 13/22] target/i386/sev: Remove stubs by using code elision, (continued)
- [PATCH v3 12/22] target/i386/sev: Declare system-specific functions in 'sev_i386.h', Philippe Mathieu-Daudé, 2021/10/02
- [PATCH v3 11/22] target/i386/sev: Restrict SEV to system emulation, Philippe Mathieu-Daudé, 2021/10/02
- [PATCH v3 14/22] target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c, Philippe Mathieu-Daudé, 2021/10/02
- [PATCH v3 15/22] target/i386/sev: Move qmp_sev_inject_launch_secret() to sev.c, Philippe Mathieu-Daudé, 2021/10/02
- [PATCH v3 16/22] target/i386/sev: Move qmp_query_sev_capabilities() to sev.c, Philippe Mathieu-Daudé, 2021/10/02
- [PATCH v3 17/22] target/i386/sev: Move qmp_query_sev_launch_measure() to sev.c, Philippe Mathieu-Daudé, 2021/10/02
- [PATCH v3 18/22] target/i386/sev: Move qmp_query_sev() & hmp_info_sev() to sev.c, Philippe Mathieu-Daudé, 2021/10/02