[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6] Improve consistency of bus init function names
From: |
Peter Maydell |
Subject: |
Re: [PATCH 0/6] Improve consistency of bus init function names |
Date: |
Thu, 30 Sep 2021 10:39:54 +0100 |
On Thu, 23 Sept 2021 at 13:11, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> Currently we have a bit of a mishmash of different function
> names for bus creation. There are two basic patterns: you
> can have a function that allocates and returns a new bus
> object; or you can have a function that takes a pointer to
> a bus object and initializes it in-place. We have to some
> extent a convention for those: the allocate-and-return
> function is 'foo_new()', and the 'init in-place' function
> is 'foo_init()'. However many of our bus creation functions
> don't follow that; some use 'foo_new' vs 'foo_new_inplace';
> some use 'foo_new' for the in-place init version; and
> the bottom level qbus functions are 'qbus_create' vs
> 'qbus_create_inplace'. This series tries to bring at least
> scsi, ipack, pci, ide, and qbus into line with the
> _new-vs-_init naming convention.
Thanks all for the reviews/acks. I'm going to take this via
target-arm.next.
-- PMM
- Re: [PATCH 1/6] scsi: Replace scsi_bus_new() with scsi_bus_init(), scsi_bus_init_named(), (continued)
- [PATCH 2/6] ipack: Rename ipack_bus_new_inplace() to ipack_bus_init(), Peter Maydell, 2021/09/23
- [PATCH 6/6] ide: Rename ide_bus_new() to ide_bus_init(), Peter Maydell, 2021/09/23
- [PATCH 4/6] qbus: Rename qbus_create_inplace() to qbus_init(), Peter Maydell, 2021/09/23
- [PATCH 3/6] pci: Rename pci_root_bus_new_inplace() to pci_root_bus_init(), Peter Maydell, 2021/09/23
- [PATCH 5/6] qbus: Rename qbus_create() to qbus_new(), Peter Maydell, 2021/09/23
- Re: [PATCH 0/6] Improve consistency of bus init function names, Philippe Mathieu-Daudé, 2021/09/23
- Re: [PATCH 0/6] Improve consistency of bus init function names, Michael S. Tsirkin, 2021/09/23
- Re: [PATCH 0/6] Improve consistency of bus init function names,
Peter Maydell <=