Re: [PATCH v5 8/9] migration/ram: Factor out populating pages readable in ram_block_populate_pages()

[David Hildenbrand]

On 28.09.21 17:34, Peter Xu wrote:
> On Sat, Sep 04, 2021 at 06:09:12PM +0200, David Hildenbrand wrote:
> > Let's factor out prefaulting/populating to make further changes easier to
> > review and add a comment what we are actually expecting to happen. While at
> > it, use the actual page size of the ramblock, which defaults to
> > qemu_real_host_page_size for anonymous memory. Further, rename
> > ram_block_populate_pages() to ram_block_populate_read() as well, to make
> > it clearer what we are doing.
> >
> > In the future, we might want to use MADV_POPULATE_READ to speed up
> > population.
> >
> > Signed-off-by: David Hildenbrand <david@redhat.com>
>
> Reviewed-by: Peter Xu <peterx@redhat.com>

Thanks Peter!

--
Thanks,

David / dhildenb