qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 26/30] tcg/loongarch64: Implement tcg_target_init


From: Richard Henderson
Subject: Re: [PATCH v6 26/30] tcg/loongarch64: Implement tcg_target_init
Date: Sun, 26 Sep 2021 19:07:11 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 9/26/21 3:15 AM, Philippe Mathieu-Daudé wrote:
On 9/25/21 19:30, WANG Xuerui wrote:
Signed-off-by: WANG Xuerui <git@xen0n.name>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
  tcg/loongarch64/tcg-target.c.inc | 27 +++++++++++++++++++++++++++
  1 file changed, 27 insertions(+)

+static void tcg_target_init(TCGContext *s)
+{
+    tcg_target_available_regs[TCG_TYPE_I32] = ALL_GENERAL_REGS;
+    tcg_target_available_regs[TCG_TYPE_I64] = ALL_GENERAL_REGS;
+
+    tcg_target_call_clobber_regs = ALL_GENERAL_REGS;

If you plan to add support for vector registers later, I think it is
safer to start today with:

        tcg_target_call_clobber_regs = -1ull;

It is not "safer", it is wrong -- there are bits set for which there are no 
registers.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]