[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/11] qdev: Avoid using string visitor for properties
From: |
Eric Blake |
Subject: |
Re: [PATCH 04/11] qdev: Avoid using string visitor for properties |
Date: |
Fri, 24 Sep 2021 13:40:46 -0500 |
User-agent: |
NeoMutt/20210205-773-8890a5 |
On Fri, Sep 24, 2021 at 11:04:20AM +0200, Kevin Wolf wrote:
> The only thing the string visitor adds compared to a keyval visitor is
> list support. git grep for 'visit_start_list' and 'visit.*List' shows
> that devices don't make use of this.
>
> In a world with a QAPIfied command line interface, the keyval visitor is
> used to parse the command line. In order to make sure that no devices
> start using this feature that would make backwards compatibility harder,
> just switch away from object_property_parse(), which internally uses the
> string visitor, to a keyval visitor and object_property_set().
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> softmmu/qdev-monitor.c | 20 +++++++++++++++++---
> 1 file changed, 17 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH 00/11] qdev: Add JSON -device and fix QMP device_add, Kevin Wolf, 2021/09/24
- [PATCH 01/11] qom: Reduce use of error_propagate(), Kevin Wolf, 2021/09/24
- [PATCH 02/11] iotests/245: Fix type for iothread property, Kevin Wolf, 2021/09/24
- [PATCH 03/11] iotests/051: Fix typo, Kevin Wolf, 2021/09/24
- [PATCH 04/11] qdev: Avoid using string visitor for properties, Kevin Wolf, 2021/09/24
- Re: [PATCH 04/11] qdev: Avoid using string visitor for properties,
Eric Blake <=
- [PATCH 05/11] qdev: Make DeviceState.id independent of QemuOpts, Kevin Wolf, 2021/09/24
- [PATCH 08/11] qdev: Base object creation on QDict rather than QemuOpts, Kevin Wolf, 2021/09/24
- [PATCH 07/11] qemu-option: Allow deleting opts during qemu_opts_foreach(), Kevin Wolf, 2021/09/24
- [PATCH 06/11] qdev: Add Error parameter to qdev_set_id(), Kevin Wolf, 2021/09/24