[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 05/20] nubus: move slot bitmap checks from NubusDevice realize
From: |
Mark Cave-Ayland |
Subject: |
[PATCH v5 05/20] nubus: move slot bitmap checks from NubusDevice realize() to BusClass check_address() |
Date: |
Thu, 23 Sep 2021 10:12:53 +0100 |
Allow Nubus to manage the slot allocations itself using the BusClass
check_address()
virtual function rather than managing this during NubusDevice realize().
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
hw/nubus/nubus-bus.c | 30 ++++++++++++++++++++++++++++++
hw/nubus/nubus-device.c | 22 ----------------------
2 files changed, 30 insertions(+), 22 deletions(-)
diff --git a/hw/nubus/nubus-bus.c b/hw/nubus/nubus-bus.c
index 3cd7534864..d4daaa36f2 100644
--- a/hw/nubus/nubus-bus.c
+++ b/hw/nubus/nubus-bus.c
@@ -96,11 +96,41 @@ static void nubus_init(Object *obj)
NUBUS_SLOT_NB);
}
+static bool nubus_check_address(BusState *bus, DeviceState *dev, Error **errp)
+{
+ NubusDevice *nd = NUBUS_DEVICE(dev);
+ NubusBus *nubus = NUBUS_BUS(bus);
+ uint16_t s;
+
+ if (nd->slot == -1) {
+ /* No slot specified, find first available free slot */
+ s = ctz32(nubus->slot_available_mask);
+ if (s != 32) {
+ nd->slot = s;
+ } else {
+ error_setg(errp, "Cannot register nubus card, no free slot "
+ "available");
+ return false;
+ }
+ } else {
+ /* Slot specified, make sure the slot is available */
+ if (!(nubus->slot_available_mask & BIT(nd->slot))) {
+ error_setg(errp, "Cannot register nubus card, slot %d is "
+ "unavailable or already occupied", nd->slot);
+ return false;
+ }
+ }
+
+ nubus->slot_available_mask &= ~BIT(nd->slot);
+ return true;
+}
+
static void nubus_class_init(ObjectClass *oc, void *data)
{
BusClass *bc = BUS_CLASS(oc);
bc->realize = nubus_realize;
+ bc->check_address = nubus_check_address;
}
static const TypeInfo nubus_bus_info = {
diff --git a/hw/nubus/nubus-device.c b/hw/nubus/nubus-device.c
index 562650a05b..516b13d2d5 100644
--- a/hw/nubus/nubus-device.c
+++ b/hw/nubus/nubus-device.c
@@ -160,28 +160,6 @@ static void nubus_device_realize(DeviceState *dev, Error
**errp)
NubusDevice *nd = NUBUS_DEVICE(dev);
char *name;
hwaddr slot_offset;
- uint16_t s;
-
- if (nd->slot == -1) {
- /* No slot specified, find first available free slot */
- s = ctz32(nubus->slot_available_mask);
- if (s != 32) {
- nd->slot = s;
- } else {
- error_setg(errp, "Cannot register nubus card, no free slot "
- "available");
- return;
- }
- } else {
- /* Slot specified, make sure the slot is available */
- if (!(nubus->slot_available_mask & BIT(nd->slot))) {
- error_setg(errp, "Cannot register nubus card, slot %d is "
- "unavailable or already occupied", nd->slot);
- return;
- }
- }
-
- nubus->slot_available_mask &= ~BIT(nd->slot);
/* Super */
slot_offset = nd->slot * NUBUS_SUPER_SLOT_SIZE;
--
2.20.1
- [PATCH v5 03/20] nubus-device: expose separate super slot memory region, (continued)
[PATCH v5 05/20] nubus: move slot bitmap checks from NubusDevice realize() to BusClass check_address(),
Mark Cave-Ayland <=
[PATCH v5 06/20] nubus: implement BusClass get_dev_path(), Mark Cave-Ayland, 2021/09/23
[PATCH v5 07/20] nubus: add trace-events for empty slot accesses, Mark Cave-Ayland, 2021/09/23
[PATCH v5 08/20] nubus: generate bus error when attempting to access empty slots, Mark Cave-Ayland, 2021/09/23
[PATCH v5 09/20] macfb: don't register declaration ROM, Mark Cave-Ayland, 2021/09/23
[PATCH v5 10/20] nubus-device: remove nubus_register_rom() and nubus_register_format_block(), Mark Cave-Ayland, 2021/09/23
[PATCH v5 11/20] nubus-device: add romfile property for loading declaration ROMs, Mark Cave-Ayland, 2021/09/23
[PATCH v5 12/20] nubus: move nubus to its own 32-bit address space, Mark Cave-Ayland, 2021/09/23